Skip to content

allow running tests without GAPDoc loaded #6172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 1 commit into from
Dec 12, 2025
Merged

allow running tests without GAPDoc loaded #6172

fingolfin merged 1 commit into from
Dec 12, 2025

Conversation

@ThomasBreuer
Copy link
Contributor

@ThomasBreuer ThomasBreuer commented Dec 11, 2025

addresses #6071

@ThomasBreuer ThomasBreuer added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: tests issues or PRs related to tests release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Dec 11, 2025
@limakzi
Copy link
Member

limakzi commented Dec 11, 2025

This change is simple, but I do not have feeling it addresses issue precisely.

My feeling is that we should still be able get diffs. Either ANSI escape sequences or just plaintext would be great.

fingolfin
fingolfin approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense (I did run into this before myself).

Of course as @limakzi points out, it'd be great to get colors in the diffs even without GAPDoc, but that's outside of what this PR tries to achieve. Clearly, being able to run the tests at all is strictly better than not being able to run them at all.

@fingolfin fingolfin merged commit 910df18 into gap-system:master Dec 12, 2025
32 checks passed
@fingolfin
Copy link
Member

fingolfin commented Dec 12, 2025

This change is simple, but I do not have feeling it addresses issue precisely.

My feeling is that we should still be able get diffs. Either ANSI escape sequences or just plaintext would be great.

Actually, you still get diffs, just without colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees

No one assigned

Labels

backport-to-4.15 kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: tests issues or PRs related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasBreuer @limakzi @fingolfin